[Lldb-commits] [PATCH] D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms

Aaron Smith via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Apr 11 19:53:08 PDT 2019


asmith marked an inline comment as done.
asmith added inline comments.


================
Comment at: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp:74-78
+#if defined(_WIN32)
+  fprintf(stderr, "PID: %d\n", ::GetCurrentProcessId());
+#else
   fprintf(stderr, "PID: %d\n", getpid());
+#endif
----------------
clayborg wrote:
> Is there no llvm host code we can use as the porting layer instead of this?
If the test harness was changed to link against the host support libraries and included the right header this could be factored out. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60496/new/

https://reviews.llvm.org/D60496





More information about the lldb-commits mailing list