[Lldb-commits] [PATCH] D59370: Return llvm::Error and llvm::Expected from some DWARF parsing functions

[Zachary Turner via lldb-commits]

On Thu, Mar 14, 2019 at 11:48 AM Greg Clayton via Phabricator <
reviews at reviews.llvm.org> wrote:

> clayborg accepted this revision.
> clayborg added a comment.
> This revision is now accepted and ready to land.
>
> As long as there is not a large performance regress when parsing large
> DWARF files this looks good to me. Abbreviation declarations are small, so
> I don't expect one.
>
>
>
> ================
> Comment at:
> lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.cpp:37-42
> +  if (m_tag == DW_TAG_null) {
> +    // FIXME: According to the DWARF spec this may actually be malformed.
> +    // Should this return an error instead?
> +    return DWARFEnumState::Complete;
> +  }
> +
> ----------------
> Seems like this would be malformed and should be an error. Something about
> NULL tag when valid tag was expected
>

Forgot to address this before submitting.  Will do so in a followup.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190314/31530216/attachment.html>