[Lldb-commits] [PATCH] D59370: Return llvm::Error and llvm::Expected from some DWARF parsing functions

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 14 11:48:12 PDT 2019

clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

As long as there is not a large performance regress when parsing large DWARF files this looks good to me. Abbreviation declarations are small, so I don't expect one.

Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.cpp:37-42
+  if (m_tag == DW_TAG_null) {
+    // FIXME: According to the DWARF spec this may actually be malformed.
+    // Should this return an error instead?
+    return DWARFEnumState::Complete;
+  }
Seems like this would be malformed and should be an error. Something about NULL tag when valid tag was expected



More information about the lldb-commits mailing list