[Lldb-commits] [PATCH] D56595: SymbolFileBreakpad: Add line table support

[Pavel Labath via Phabricator via lldb-commits]

labath updated this revision to Diff 185533.
labath marked 2 inline comments as done.
labath added a comment.

Tried to make parsing as lazy as possible. GetNumSections() will count the
number of FUNC records, but will not create CompileUnit objects. FILE records
will be parsed when we create the first compile unit. The support files and line
tables will be parsed when the first of them is requested for a given CU.

I've removed the CU shared pointer from the CompUnitData structure. Instead, I go through the symbol vendor to fetch the CU SP.

Added the move constructor for FileSpecList.

Please take another look.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56595/new/

https://reviews.llvm.org/D56595

Files:
  include/lldb/Core/FileSpecList.h
  include/lldb/Core/RangeMap.h
  lit/SymbolFile/Breakpad/Inputs/line-table-discontinuous-file-ids.syms
  lit/SymbolFile/Breakpad/Inputs/line-table-edgecases.syms
  lit/SymbolFile/Breakpad/Inputs/line-table-missing-file.syms
  lit/SymbolFile/Breakpad/Inputs/line-table.syms
  lit/SymbolFile/Breakpad/line-table-discontinuous-file-ids.test
  lit/SymbolFile/Breakpad/line-table-edgecases.test
  lit/SymbolFile/Breakpad/line-table-missing-file.test
  lit/SymbolFile/Breakpad/line-table.test
  source/Core/FileSpecList.cpp
  source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp
  source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56595.185533.patch
Type: text/x-patch
Size: 28569 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190206/82876f31/attachment-0001.bin>