[Lldb-commits] [PATCH] D56595: SymbolFileBreakpad: Add line table support

Leonard Mosescu via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 5 11:58:13 PST 2019


lemo accepted this revision.
lemo added a comment.
This revision is now accepted and ready to land.

The latest version looks good to me. Please update the description (it still says it uses the one CU per symbols file)



================
Comment at: include/lldb/Core/FileSpecList.h:72
+  /// Move-assignment operator.
+  FileSpecList &operator=(FileSpecList &&rhs) = default;
 
----------------
nit: if you have move assignment-operator also add the move constructor


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56595/new/

https://reviews.llvm.org/D56595





More information about the lldb-commits mailing list