[Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

Aleksandr Urakov via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 6 01:07:34 PST 2019

aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: zturner, labath, stella.stamenova.
aleksandr.urakov added a project: LLDB.
Herald added a reviewer: serge-sans-paille.
Herald added a subscriber: lldb-commits.

On my system, `clang-cl` can't compile tests containing `char16_t` and `char32_t` types without this environment variable defined. This fix makes the tests to pass, but I'm not sure about the such solution. What do you think about it?




Index: lit/helper/build.py
--- lit/helper/build.py
+++ lit/helper/build.py
@@ -512,7 +512,7 @@
         defaultenv = {}
         if sys.platform == 'win32':
             defaultenv = { x : os.environ[x] for x in
-                          ['SystemDrive', 'SystemRoot', 'TMP', 'TEMP'] }
+                          ['SystemDrive', 'SystemRoot', 'TMP', 'TEMP', 'VCINSTALLDIR'] }
             # The directory to mspdbcore.dll needs to be in PATH, but this is
             # always in the native toolchain path, not the cross-toolchain
             # path.  So, for example, if we're using HostX64\x86 then we need

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57809.185502.patch
Type: text/x-patch
Size: 678 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190206/cf3137d9/attachment.bin>

More information about the lldb-commits mailing list