[Lldb-commits] [PATCH] D57750: [CMake] Don't add `cxx` to `LLDB_TEST_DEPS` if it doesn't exist.
Stefan Gränitz via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Feb 5 09:04:22 PST 2019
sgraenitz added a comment.
Not sure if we want to change the behavior this way. The purpose of this code was to make the dependency to libc++ explicit because it's specific to macOS and it's missed quite often. In my experience warnings like the proposed one are hard to recognize in the load of CMake output.
Note that you can configure with `LLDB_INCLUDE_TESTS=OFF` to avoid the libc++ dependency. We could have an explicit error message that points this out. What do you think?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits