[Lldb-commits] [PATCH] D57750: [CMake] Don't add `cxx` to `LLDB_TEST_DEPS` if it doesn't exist.

Dan Liew via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 5 06:37:31 PST 2019


delcypher added a comment.

Wow phabricator has made a right mess of displaying this patch. It's easier to look at as.

  diff --git a/lldb/CMakeLists.txt b/lldb/CMakeLists.txt
  index fdd84a6e7b7..6b26adb3383 100644
  --- a/lldb/CMakeLists.txt
  +++ b/lldb/CMakeLists.txt
  @@ -111,7 +111,11 @@ if(LLDB_INCLUDE_TESTS)
             message(WARNING "LLDB test suite requires libc++ in llvm/projects/libcxx or an existing build symlinked to ${cxx_dir}")
           endif()
         else()
  -        list(APPEND LLDB_TEST_DEPS cxx)
  +        if (NOT TARGET cxx)
  +          message(WARNING "LLDB test suite requires libc++")
  +        else()
  +          list(APPEND LLDB_TEST_DEPS cxx)
  +        endif()
         endif()
       endif()
     endif()


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57750/new/

https://reviews.llvm.org/D57750





More information about the lldb-commits mailing list