[Lldb-commits] [PATCH] D56763: [CMake] Prevent lldbDebugserverCommon from building if you disable debugserver builds
Stefan Gränitz via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Jan 16 06:34:41 PST 2019
sgraenitz added a comment.
Yes this sounds very reasonable.
One little detail is, that on Darwin the `debugserverTests` unit test target depends on `lldbDebugserverCommon`.
In `unittests/CMakeLists.txt` it's included `if(LLDB_CAN_USE_DEBUGSERVER)`, which should be changed to `if(NOT SKIP_TEST_DEBUGSERVER)` now. IIUC this would make sense anyway.
CHANGES SINCE LAST ACTION
More information about the lldb-commits