[Lldb-commits] [PATCH] D56763: [CMake] Prevent lldbDebugserverCommon from building if you disable debugserver builds

[Alex Langford via Phabricator via lldb-commits]

xiaobai created this revision.
xiaobai added reviewers: sgraenitz, davide, JDevlieghere, beanz, vsk, aprantl, labath.
Herald added subscribers: jfb, mgorny.

The flags `LLDB_USE_SYSTEM_DEBUGSERVER` and `LLDB_NO_DEBUGSERVER` were
introduced to the debugserver build. If one of these two flags are set, then we
do not build and sign debugserver. However I noticed that we were still building
the lldbDebugserverCommon and lldbDebugserverCommon_NonUI libraries regardless
of whether or not these flags were set. I don't believe we should be building
these libraries unless we are building and signing debugserver.


https://reviews.llvm.org/D56763

Files:
  tools/debugserver/source/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56763.181941.patch
Type: text/x-patch
Size: 6672 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190116/683c02de/attachment.bin>