[Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

Stella Stamenova via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 12 12:31:47 PDT 2018

Thanks, I’ve been monitoring the bots also and it looks like they haven’t picked up the zorg change yet. I don’t know if that’s supposed to just happen or if there’s something that needs to be done or if there’s a schedule for when they update.


From: vsk at apple.com <vsk at apple.com>
Sent: Friday, October 12, 2018 11:33 AM
To: Stella Stamenova <stilis at microsoft.com>
Cc: Zachary Turner <zturner at google.com>; lldb-commits at lists.llvm.org; reviews+D53175+public+09519a8f992e0e1a at reviews.llvm.org
Subject: Re: [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

All right, Committed r344396, I’ll keep an eye out for failures.


On Oct 12, 2018, at 9:58 AM, Stella Stamenova <stilis at microsoft.com<mailto:stilis at microsoft.com>> wrote:

Those changes look reasonable, but I don't know how to test it either. I would be in favor of checking it in because the buildbots are currently broken and this can't make it worse, right?

-----Original Message-----
From: vsk at apple.com<mailto:vsk at apple.com> <vsk at apple.com<mailto:vsk at apple.com>>
Sent: Thursday, October 11, 2018 3:56 PM
To: Stella Stamenova <stilis at microsoft.com<mailto:stilis at microsoft.com>>
Cc: Zachary Turner <zturner at google.com<mailto:zturner at google.com>>; lldb-commits at lists.llvm.org<mailto:lldb-commits at lists.llvm.org>; reviews+D53175+public+09519a8f992e0e1a at reviews.llvm.org<mailto:reviews+D53175+public+09519a8f992e0e1a at reviews.llvm.org>
Subject: Re: [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

Does this look reasonable to you? I'm not sure how to test this.

diff --git a/zorg/buildbot/builders/LLDBBuilder.py b/zorg/buildbot/builders/LLDBBuilder.py
index 5a1b2e87..62152924 100644
--- a/zorg/buildbot/builders/LLDBBuilder.py
+++ b/zorg/buildbot/builders/LLDBBuilder.py
@@ -270,6 +270,7 @@ def getLLDBTestSteps(f,
            compilerPath = compiler
        for arch in test_archs:
            DOTEST_OPTS=''.join(['--executable ' + bindir + '/lldb ',
+                                 '--filecheck ' + bindir + '/FileCheck
+ ',
                                 '-A %s ' % arch,
                                 '-C %s ' % compilerPath,
                                 '-s lldb-test-traces-%s-%s ' % (compiler, arch), @@ -819,6 +820,7 @@ def getLLDBxcodebuildFactory(use_cc=None,
    DOTEST_OPTS = ' '.join(['--executable',
+                            '%(lldb_bindir)s/FileCheck',
                            '--framework', '%(lldb_bindir)s/LLDB.framework',
                            '-A', 'x86_64',
                            '-C', 'clang',


On Oct 11, 2018, at 3:46 PM, Stella Stamenova via Phabricator <reviews at reviews.llvm.org<mailto:reviews at reviews.llvm.org>> wrote:

stella.stamenova added a comment.

The failing bots are not windows bots but Linux bots. It looks like you only updated the configurations for xcode.

I think the file that needs to be updated is:



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181012/2e230341/attachment-0001.html>

More information about the lldb-commits mailing list