<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Helvetica;
panose-1:2 11 6 4 2 2 2 2 2 4;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.apple-converted-space
{mso-style-name:apple-converted-space;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">Thanks, I’ve been monitoring the bots also and it looks like they haven’t picked up the zorg change yet. I don’t know if that’s supposed to just happen or if there’s something that needs to be done or if there’s a schedule for when they
update.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal">-Stella<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> vsk@apple.com <vsk@apple.com> <br>
<b>Sent:</b> Friday, October 12, 2018 11:33 AM<br>
<b>To:</b> Stella Stamenova <stilis@microsoft.com><br>
<b>Cc:</b> Zachary Turner <zturner@google.com>; lldb-commits@lists.llvm.org; reviews+D53175+public+09519a8f992e0e1a@reviews.llvm.org<br>
<b>Subject:</b> Re: [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">All right, Committed r344396, I’ll keep an eye out for failures.<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">vedant<o:p></o:p></p>
<div>
<p class="MsoNormal"><br>
<br>
<o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">On Oct 12, 2018, at 9:58 AM, Stella Stamenova <<a href="mailto:stilis@microsoft.com">stilis@microsoft.com</a>> wrote:<o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif">Those changes look reasonable, but I don't know how to test it either. I would be in favor of checking it in because the buildbots are currently broken and this can't make
it worse, right?<br>
<br>
-----Original Message-----<br>
From:<span class="apple-converted-space"> </span></span><a href="mailto:vsk@apple.com"><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif">vsk@apple.com</span></a><span class="apple-converted-space"><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif"> </span></span><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif"><</span><a href="mailto:vsk@apple.com"><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif">vsk@apple.com</span></a><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif">><span class="apple-converted-space"> </span><br>
Sent: Thursday, October 11, 2018 3:56 PM<br>
To: Stella Stamenova <</span><a href="mailto:stilis@microsoft.com"><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif">stilis@microsoft.com</span></a><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif">><br>
Cc: Zachary Turner <</span><a href="mailto:zturner@google.com"><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif">zturner@google.com</span></a><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif">>;<span class="apple-converted-space"> </span></span><a href="mailto:lldb-commits@lists.llvm.org"><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif">lldb-commits@lists.llvm.org</span></a><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif">;<span class="apple-converted-space"> </span></span><a href="mailto:reviews+D53175+public+09519a8f992e0e1a@reviews.llvm.org"><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif">reviews+D53175+public+09519a8f992e0e1a@reviews.llvm.org</span></a><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif"><br>
Subject: Re: [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error<br>
<br>
Does this look reasonable to you? I'm not sure how to test this.<br>
<br>
diff --git a/zorg/buildbot/builders/LLDBBuilder.py b/zorg/buildbot/builders/LLDBBuilder.py<br>
index 5a1b2e87..62152924 100644<br>
--- a/zorg/buildbot/builders/LLDBBuilder.py<br>
+++ b/zorg/buildbot/builders/LLDBBuilder.py<br>
@@ -270,6 +270,7 @@ def getLLDBTestSteps(f,<br>
compilerPath = compiler<br>
for arch in test_archs:<br>
DOTEST_OPTS=''.join(['--executable ' + bindir + '/lldb ',<br>
+ '--filecheck ' + bindir + '/FileCheck<span class="apple-converted-space"> </span><br>
+ ',<br>
'-A %s ' % arch,<br>
'-C %s ' % compilerPath,<br>
'-s lldb-test-traces-%s-%s ' % (compiler, arch), @@ -819,6 +820,7 @@ def getLLDBxcodebuildFactory(use_cc=None,<br>
workdir=lldb_srcdir))<br>
DOTEST_OPTS = ' '.join(['--executable',<br>
'%(lldb_bindir)s/lldb',<br>
+ '%(lldb_bindir)s/FileCheck',<br>
'--framework', '%(lldb_bindir)s/LLDB.framework',<br>
'-A', 'x86_64',<br>
'-C', 'clang',<br>
<br>
vedant<br>
<br style="caret-color: rgb(0, 0, 0);font-variant-caps: normal;text-align:start;-webkit-text-stroke-width: 0px;word-spacing:0px">
<br>
</span><o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif">On Oct 11, 2018, at 3:46 PM, Stella Stamenova via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br>
<br>
stella.stamenova added a comment.<br>
<br>
The failing bots are not windows bots but Linux bots. It looks like you only updated the configurations for xcode.<br>
<br>
I think the file that needs to be updated is:<br>
<br>
zorg\buildbot\builders\LLDBBuilder.py<br>
<br>
<br>
<a href="https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Frevie">https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Frevie</a><br>
<a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fws.llvm.org%2F&data=02%7C01%7Cstilis%40microsoft.com%7C4ed280cd33e449b8d05708d630712aed%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636749659954498980&sdata=dhL6bP%2BmjReY6WIzw4F8K8FXX0dIHB64cJv%2BykrOHDc%3D&reserved=0">ws.llvm.org</a>%2FD53175&data=02%7C01%7CSTILIS%<a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40microsoft.com%2F&data=02%7C01%7Cstilis%40microsoft.com%7C4ed280cd33e449b8d05708d630712aed%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636749659954498980&sdata=%2FnKkN0v3DrJ%2FW4CQv987wTURI%2BMoHptOEczJKuxbr6k%3D&reserved=0">40microsoft.com</a>%7Cb8693<br>
c9edfa5449d97db08d62fccaacd%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0<br>
%7C636748953431151967&sdata=rdn7nntFECouzbw%2FPoQISVCGGrjLCqAygk8q<br>
l0St%2B5o%3D&reserved=0<o:p></o:p></span></p>
</blockquote>
</div>
</blockquote>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</body>
</html>