[Lldb-commits] [PATCH] D47991: Improve SBThread's stepping API using SBError parameter.

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jun 13 08:59:44 PDT 2018

clayborg added a comment.

In https://reviews.llvm.org/D47991#1131181, @apolyakov wrote:

> In https://reviews.llvm.org/D47991#1131043, @clayborg wrote:
> > Looks good. Just a question about including the commented out default arguments
> Don't you think it increases readability of this code?

It does if it stays in sync. This isn't done anywhere else and I don't believe it is in the LLVM coding conventions. If it is, please correct me. I didn't mark this as Request Changes as I wanted to gauge what others think. I am happy to go either way, but if we do go this way, it will have impact on all patches going forward so I wanted to point it out for discussion.


More information about the lldb-commits mailing list