[Lldb-commits] [PATCH] D48049: Add a new SBTarget::LoadCore() overload which surfaces errors if the load fails
Leonard Mosescu via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Jun 11 13:26:55 PDT 2018
lemo created this revision.
lemo added reviewers: zturner, clayborg, amccarth.
There was no way to find out what's wrong if SBProcess SBTarget::LoadCore(const char *core_file) failed.
Additionally, the implementation was unconditionally setting sb_process, so it wasn't even possible to check if the return SBProcess is valid.
This change adds a new overload which surfaces the errors and also returns a valid SBProcess only if the core load succeeds:
SBProcess SBTarget::LoadCore(const char *core_file, SBError &error);
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 17639 bytes
Desc: not available
More information about the lldb-commits