[Lldb-commits] [PATCH] D47991: Improve SBThread's stepping API using SBError parameter.

Leonard Mosescu via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 11 19:36:17 PDT 2018


lemo added subscribers: clayborg, jingham, labath, apolyakov.
lemo added a comment.

> Ah I see. That's because the last argument is a C++ default argument. It
>  looks like the convention in this file is that the error argument should be
>  the last non-defaulted argument.

I think it should be:

void StepOver(lldb::RunMode stop_other_threads, lldb::SBError &error); //
no default argument!

Ie. if you want the overload with error you need to pass RunMode
explicitly. Keeping the overload set manageable is a good practice in
general, not just because of SWIG (default arguments + overloaded arguments
can easily get out of hand)


https://reviews.llvm.org/D47991





More information about the lldb-commits mailing list