[Lldb-commits] [PATCH] D47991: Improve SBThread's stepping API using SBError parameter.

[Leonard Mosescu via lldb-commits]

>
> Ah I see. That's because the last argument is a C++ default argument. It
> looks like the convention in this file is that the error argument should be
> the last non-defaulted argument.


I think it should be:

void StepOver(lldb::RunMode stop_other_threads, lldb::SBError &error); //
no default argument!

Ie. if you want the overload with error you need to pass RunMode
explicitly. Keeping the overload set manageable is a good practice in
general, not just because of SWIG (default arguments + overloaded arguments
can easily get out of hand)



On Mon, Jun 11, 2018 at 5:51 PM, Adrian Prantl via Phabricator <
reviews at reviews.llvm.org> wrote:

> aprantl accepted this revision.
> aprantl added a comment.
>
> Ah I see. That's because the last argument is a C++ default argument. It
> looks like the convention in this file is that the error argument should be
> the last non-defaulted argument.
>
>
> https://reviews.llvm.org/D47991
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180611/d8caf3d7/attachment.html>