[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

Aleksandr Urakov via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 7 03:25:55 PDT 2018

aleksandr.urakov added a comment.

In https://reviews.llvm.org/D47708#1124743, @labath wrote:

> We have an lldb-test executable, which we use for writing tests (see tests in lit/SymbolFile). It's `symbols` subcommand currently just dumps their contents and then we match that.
> Your checks don't have any assumptions about the input hardcoded in them. This may be both good and bad, but anyway, my idea was to add a `--verify` flag to lldb-test (similar to how `llvm-dwarfdump --verify` works) which would run these checks (and any other we can think of later). Then, the test would simply consist of running `lldb-test symbols --verify your.exe` and asserting that it returns success.

Thank you, I'll implement this. Will be it better to create a different review for this?


More information about the lldb-commits mailing list