[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In https://reviews.llvm.org/D47708#1124733, @aleksandr.urakov wrote:

> > I think these kinds of checks would be a nice fit for a lldb-test symbols --verify option.
>
> Can you explain this in detail, please?


We have an lldb-test executable, which we use for writing tests (see tests in lit/SymbolFile). It's `symbols` subcommand currently just dumps their contents and then we match that.

Your checks don't have any assumptions about the input hardcoded in them. This may be both good and bad, but anyway, my idea was to add a `--verify` flag to lldb-test (similar to how `llvm-dwarfdump --verify` works) which would run these checks (and any other we can think of later). Then, the test would simply consist of running `lldb-test symbols --verify your.exe` and asserting that it returns success.


https://reviews.llvm.org/D47708