[Lldb-commits] [PATCH] D47781: DebugNamesDWARFIndex: Add ability to lookup variables

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 5 12:38:40 PDT 2018

labath added inline comments.

Comment at: source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp:70
+      continue;
+    Append(entry, offsets);
clayborg wrote:
> Need to check for the context matches here if context is not empty.
Hmm... thanks for pointing this out. There is some index-independent filtering based on CompilerDeclContexts happening in SymbolFileDWARF (which is why my context test actually passes here).

I was basing this off of how apple and manual indexes work, and neither of them check the context. In fact, the manual index does not even extract the identifier portion of the name (it just looks up the whole string), so maybe nobody passes qualified names names into this function anyway? I am starting to think I should just remove the `ExtractContextAndIdentifier` call. If we see failures down the line, at least we will learn why was this call there in the first place.


More information about the lldb-commits mailing list