[Lldb-commits] [PATCH] D47781: DebugNamesDWARFIndex: Add ability to lookup variables

[Greg Clayton via Phabricator via lldb-commits]

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

Check the context as noted in inline comments.



================
Comment at: source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp:70
+      continue;
+
+    Append(entry, offsets);
----------------
Need to check for the context matches here if context is not empty.


================
Comment at: source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.h:14
 #include "Plugins/SymbolFile/DWARF/DWARFIndex.h"
+#include "Plugins/SymbolFile/DWARF/LogChannelDWARF.h"
 #include "lldb/Utility/ConstString.h"
----------------
move to .cpp file?


https://reviews.llvm.org/D47781