[Lldb-commits] [PATCH] D47275: 1/3: DWARFDIE split out to DWARFBasicDIE

Jan Kratochvil via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu May 24 02:21:37 PDT 2018

jankratochvil marked 5 inline comments as done.
jankratochvil added a comment.

In https://reviews.llvm.org/D47275#1110065, @clayborg wrote:

> Marked things that don't belong in DWARFBasicDIE.

OK, sorry, thanks for reviewing it.

> Also DWARFBasicDIE doesn't really explain what it actually is. Maybe we should rename this DWARFUnitDIE? DWARFTopDIE? DWARFRootDIE?

I do not mind any name but if you do not like Pavel's `DWARFBasicDIE` and you are not sure with the name yourself I have chosen `DWARFFirstDIE`.


More information about the lldb-commits mailing list