[Lldb-commits] [PATCH] D46934: Make ObjectFileMachO work on non-darwin platforms

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu May 17 09:09:46 PDT 2018

aprantl added a comment.

In https://reviews.llvm.org/D46934#1102867, @labath wrote:

> In https://reviews.llvm.org/D46934#1101963, @aprantl wrote:
> > Does that mean we can now also remove the #ifdef __APPLE__ from the objectfile unit tests?
> Which ones do you mean? I wasn't aware we had any. The thing I know of,  which would be interesting to enable is the MachO core file tests. This can't be done yet because the respective process plugin is apple-only, but I haven't looked at what it would take to enable it everywhere.

Sorry, I was confused. I was thinking about the HostInfoMacOSX class unit test which I added at the same time and somehow the two got conflated in my memory.


More information about the lldb-commits mailing list