[Lldb-commits] [PATCH] D46934: Make ObjectFileMachO work on non-darwin platforms
Adrian Prantl via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu May 17 09:08:41 PDT 2018
aprantl added inline comments.
Comment at: source/Plugins/Process/Utility/RegisterContextDarwinConstants.h:18
+ KERNEL_SUCCESS = 0,
+ KERNEL_INVALID_ARGUMENT = 4,
I think I would prefer
#define KERN_INVALID_ARGUMENT 4
over renaming the constant. I think that that is less confusing to read and we use that pattern in other places in LLDB, too.
More information about the lldb-commits