[Lldb-commits] [PATCH] D46934: Make ObjectFileMachO work on non-darwin platforms
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed May 16 09:02:24 PDT 2018
labath added inline comments.
Comment at: source/Plugins/Process/Utility/RegisterContextDarwin_arm.cpp:1037
SetError(set, Write, -1);
- return KERN_INVALID_ARGUMENT;
+ return -1;
> Could we keep this as a local constant?
> perhaps with an #ifndef KERN_INVALID_ARGUMENT clause?
We could. I didn't do that originally, as `RegisterContextDarwin_x86_64::WriteGPR()` looks exactly like this function, and it uses `-1` already, but that works for me as well.
More information about the lldb-commits