[Lldb-commits] [PATCH] D46934: Make ObjectFileMachO work on non-darwin platforms

Jason Molenda via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed May 16 12:25:56 PDT 2018

jasonmolenda accepted this revision.
jasonmolenda added a comment.

Thanks for untangling this Pavel, I hadn't noticed we weren't building this plugin for non-darwin systems.  I'd agree with Adrian's comment that we should have a constants like LLDB_KERNEL_SUCCESS / LLDB_KERNEL_INVALID_ARGUMENT, I think the place where -1 was being returned currently would be considered incorrect (it's probably my fault for all I know ;)


More information about the lldb-commits mailing list