[Lldb-commits] [PATCH] D43912: [Symbol] Add InvalidTypeError, a force-checked recoverable error

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 1 17:18:49 PST 2018


labath added inline comments.


================
Comment at: include/lldb/Utility/Log.h:259-260
+//
+// For convenience, log may either be a Log instance or an unsigned value
+// specifying log categories.
+//
----------------
The thing to remember here is that we have multiple log channels. So the unsigned value must be a category from the "lldb" channel. That is by far the most prevalent channel, so it's probably fine that we don't have a shorthand way of specifying the other channels, but it should be called out explicitly.


https://reviews.llvm.org/D43912





More information about the lldb-commits mailing list