[Lldb-commits] [PATCH] D43912: [Symbol] Add InvalidTypeError, a force-checked recoverable error

Vedant Kumar via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 1 16:44:48 PST 2018


vsk updated this revision to Diff 136640.
vsk retitled this revision from "[Symbol] Add InvalidType, a force-checked recoverable error" to "[Symbol] Add InvalidTypeError, a force-checked recoverable error".
vsk added a comment.

- While playing around with InvalidTypeError, I found that it's useful to be able to pass a log category mask to the error-logging macros. I've implemented support for that.

- I also found that the RETURN_IF_UNEXPECTED macro is very convenient in practice. There seems to be no objection to it provided that I document how to set breakpoints for failure cases. I've brought the macro back.

Thanks for your feedback! PTAL.


https://reviews.llvm.org/D43912

Files:
  include/lldb/Symbol/CompilerType.h
  include/lldb/Utility/Log.h
  source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp
  source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.h
  source/Symbol/CompilerType.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43912.136640.patch
Type: text/x-patch
Size: 8066 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180302/77f8f749/attachment-0001.bin>


More information about the lldb-commits mailing list