[Lldb-commits] [PATCH] D43912: [Symbol] Add InvalidType, a force-checked recoverable error

[Zachary Turner via lldb-commits]

What about having the macro do the log printing in a function so you can
put the breakpoint in the function?
On Wed, Feb 28, 2018 at 5:56 PM Vedant Kumar via Phabricator <
reviews at reviews.llvm.org> wrote:

> vsk added inline comments.
>
>
> ================
> Comment at: include/lldb/Utility/Log.h:249-254
> +      ::lldb_private::Log *log_private = (log);
>       \
> +      if (log_private)
>      \
> +        log_private->FormatError(::std::move(error_private), __FILE__,
>      \
> +                                 __func__, "{0}");
>      \
> +      else
>      \
> +        ::llvm::consumeError(::std::move(error_private));
>       \
> ----------------
> labath wrote:
> > it looks like this could be just handled by delegating to the
> LLDB_LOG_ERROR macro.
> I missed this earlier because I mistakenly named two variables
> error_private. At any rate, there's an objection to having a return_if
> macro so I'm setting it aside.
>
>
> https://reviews.llvm.org/D43912
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180301/27e84705/attachment.html>