What about having the macro do the log printing in a function so you can put the breakpoint in the function?<br><div class="gmail_quote"><div dir="ltr">On Wed, Feb 28, 2018 at 5:56 PM Vedant Kumar via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">vsk added inline comments.<br>
<br>
<br>
================<br>
Comment at: include/lldb/Utility/Log.h:249-254<br>
+      ::lldb_private::Log *log_private = (log);                                \<br>
+      if (log_private)                                                         \<br>
+        log_private->FormatError(::std::move(error_private), __FILE__,         \<br>
+                                 __func__, "{0}");                             \<br>
+      else                                                                     \<br>
+        ::llvm::consumeError(::std::move(error_private));                      \<br>
----------------<br>
labath wrote:<br>
> it looks like this could be just handled by delegating to the LLDB_LOG_ERROR macro.<br>
I missed this earlier because I mistakenly named two variables error_private. At any rate, there's an objection to having a return_if macro so I'm setting it aside.<br>
<br>
<br>
<a href="https://reviews.llvm.org/D43912" rel="noreferrer" target="_blank">https://reviews.llvm.org/D43912</a><br>
<br>
<br>
<br>
</blockquote></div>