[Lldb-commits] [PATCH] D39967: Disable breakpoints before writing memory and re-enable after.

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 23 07:27:07 PST 2018

clayborg added inline comments.

Comment at: include/lldb/Breakpoint/BreakpointSiteList.h:130
+  using ModifyingCallback = std::function<bool(BreakpointSite &)>;
+  bool ForEach(const ModifyingCallback &callback);
I was a bit vague with my explanations. Only ModifyingCallback needs to return a bool. No need for the ForEach function itself to return a bool, just the callback. 

Comment at: include/lldb/Breakpoint/BreakpointSiteList.h:133
+  using Callback = std::function<bool(const BreakpointSite &)>;
+  bool ForEach(const Callback &callback) const;
Ditto, no need to return bool from ForEach.


More information about the lldb-commits mailing list