[Lldb-commits] [PATCH] D39967: Disable breakpoints before writing memory and re-enable after.

[Tatyana Krasnukha via Phabricator via lldb-commits]

tatyana-krasnukha added inline comments.


================
Comment at: include/lldb/Breakpoint/BreakpointSiteList.h:130
+  using ModifyingCallback = std::function<bool(BreakpointSite &)>;
+  bool ForEach(const ModifyingCallback &callback);
 
----------------
clayborg wrote:
> I was a bit vague with my explanations. Only ModifyingCallback needs to return a bool. No need for the ForEach function itself to return a bool, just the callback. 
If ForEach didn't apply callback for each actually, shouldn't it report an error?


https://reviews.llvm.org/D39967