[Lldb-commits] [PATCH] D42443: [SymbolFilePDB] Add support for function symbols
Zachary Turner via lldb-commits
lldb-commits at lists.llvm.org
Thu Feb 1 10:35:38 PST 2018
Yea good point. We can probably punt on this for now as it’s just a
On Thu, Feb 1, 2018 at 1:38 AM Pavel Labath via Phabricator <
reviews at reviews.llvm.org> wrote:
> labath added inline comments.
> Comment at: lit/SymbolFile/PDB/func-symbols.test:4
> +RUN: clang-cl -m32 /Z7 /c /GS- %S/Inputs/FuncSymbols.cpp /o
> +RUN: link %T/FuncSymbolsTestMain.cpp.obj %T/FuncSymbols.cpp.obj /DEBUG
> /nodefaultlib /Entry:main /OUT:%T/FuncSymbolsTest.exe
> +RUN: lldb-test symbols %T/FuncSymbolsTest.exe | FileCheck %s
> zturner wrote:
> > I bet we could get rid of `REQUIRES: windows` if we changed this to
> `lld-link`. You're already specifying `/nodefaultlib /entry:main`, and no
> windows header files are included, so maybe it's worth a try?
> That would be great, but you'd probably still need something like
> REQUIRES:lld, as lld is not currently not a mandatory requirement for
> rL LLVM
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-commits