[Lldb-commits] [PATCH] D41086: [lldb] Check that a regex is valid before searching by regex for a symbol in a pdb.
Zachary Turner via lldb-commits
lldb-commits at lists.llvm.org
Wed Dec 20 11:28:52 PST 2017
That seems reasonable. Seems Aaron ran into this not because he was trying
to do a regex search, but because he *wasnt* trying to do a regex search.
So if he doesn’t have immediate need for a regex search, and if it’s not
tested anyway, removing it seems fine
On Wed, Dec 20, 2017 at 10:49 AM Greg Clayton via Phabricator <
reviews at reviews.llvm.org> wrote:
> clayborg added a comment.
> If you load a exe file that has a PDB file, people can currently run:
> (lldb) type lookup "char*"
> If no testing is using the regular expression stuff, then just pull it
> out. Do we have unit tests that depend on this working? If not, lets just
> pull it out from the SymbolFilePDB::FindTypes() and we can leave the fix in
> that uses the RegularExpression class so it won't crash in the future?
> rL LLVM
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-commits