[Lldb-commits] [PATCH] D41086: [lldb] Check that a regex is valid before searching by regex for a symbol in a pdb.

[Zachary Turner via lldb-commits]

That seems reasonable. Seems Aaron ran into this not because he was trying
to do a regex search, but because he *wasnt* trying to do a regex search.
So if he doesn’t have immediate need for a regex search, and if it’s not
tested anyway, removing it seems fine
On Wed, Dec 20, 2017 at 10:49 AM Greg Clayton via Phabricator <
reviews at reviews.llvm.org> wrote:

> clayborg added a comment.
>
> If you load a exe file that has a PDB file, people can currently run:
>
>   (lldb) type lookup "char*"
>
> If no testing is using the regular expression stuff, then just pull it
> out.  Do we have unit tests that depend on this working? If not, lets just
> pull it out from the SymbolFilePDB::FindTypes() and we can leave the fix in
> that uses the RegularExpression class so it won't crash in the future?
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D41086
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20171220/6e44e5da/attachment.html>