[Lldb-commits] [PATCH] D41086: [lldb] Check that a regex is valid	before searching by regex for a symbol in a pdb.
    Greg Clayton via Phabricator via lldb-commits 
    lldb-commits at lists.llvm.org
       
    Wed Dec 20 10:49:14 PST 2017
    
    
  
clayborg added a comment.
If you load a exe file that has a PDB file, people can currently run:
  (lldb) type lookup "char*"
If no testing is using the regular expression stuff, then just pull it out.  Do we have unit tests that depend on this working? If not, lets just pull it out from the SymbolFilePDB::FindTypes() and we can leave the fix in that uses the RegularExpression class so it won't crash in the future?
Repository:
  rL LLVM
https://reviews.llvm.org/D41086
    
    
More information about the lldb-commits
mailing list