[Lldb-commits] [PATCH] D39825: [lldb] Fix cu_offset for dwo/dwp used by DWARFCompileUnit::Index

[Alexander Shaposhnikov via Phabricator via lldb-commits]

alexshap added a comment.

> The main point is that you should almost always interact with the SymbolFileDWARF instance belonging to the main object file and it 
> (actually DWARFCompileUnit) will know when to access data from the Dwo >file instead. 
> The original goal was to not leak pointers to SymbolFileDWARFDwo instances out from symbol file dwarf and the dwarf parsing logic.

i see ur point, let me think a bit more about it. 
One thing which i have on my mind - with that approach it's not clear (not the right wording, but anyway) how would "recursive" queries work. Whenever the "owner" SymbolFileDWARF interacts with
the SymbolFileDWARFDwo (obtained by cu->GetDwoSymbolFile()) the latter (SymbolFileDWARFDwo) may try to query itself (internally), and we will face some other issues again (if i am not mistaken).


Repository:
  rL LLVM

https://reviews.llvm.org/D39825