[Lldb-commits] [PATCH] D39825: [lldb] Fix cu_offset for dwo/dwp used by DWARFCompileUnit::Index

[Alexander Shaposhnikov via Phabricator via lldb-commits]

alexshap updated this revision to Diff 122389.
alexshap added a comment.

Change the approach: add assert to ensure we don't double index .dwo files,
rerun the tests.
@tberghammer - many thanks for the suggestions.

p.s. didn't add new tests (in this commit) - standalone repo is not trivial (objc on linux) and requires more work - probably would prefer to do this later as a follow-up (i.e. at the moment dwps are not tested yet either)


Repository:
  rL LLVM

https://reviews.llvm.org/D39825

Files:
  source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39825.122389.patch
Type: text/x-patch
Size: 5267 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20171110/8de52fa6/attachment.bin>