[Lldb-commits] [lldb] r303907 - Fix bug #28898

[Christos Zoulas via lldb-commits]

On May 30,  6:02pm, Ulrich.Weigand at de.ibm.com ("Ulrich Weigand") wrote:
-- Subject: Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898

| Hmm, from looking at the version of libedit I'm using it would
| appear that it should correctly handle either:
| - a narrow char read function installed via el=5Fset; or
| - a wide char read function installed via el=5Fwset
| which seems reasonable to me at first glance.

Yes, indeed.

| However, LLDB currently uses a wide char read function but installs
| it with el=5Fset, which is what breaks.  This would seem to be rather
| a LLDB problem, or am I missing something?

Newer version of libedit broke this compatibility:

    el_gets -> narrow_read_function
    el_wgets -> wide_read_function

and now they have:

    el_{w,}gets -> wide_read_function

I think that the best way is to put it back (i.e. narrow libedit
functions require a narrow read function), and bump the version of libedit.

Of course that does not help people who have versions of libedit that
broke this compatibility (these define el_rfunc_t in histedit.h).

christos