[Lldb-commits] [PATCH] D31172: Move stop info override callback code from ArchSpec into Process

[Jim Ingham via Phabricator via lldb-commits]

jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.

It looks like you are bundling two changes into one patch, one to move the StopInfoOverrideCallback from ArchSpec to Process, and one to change how the help for the list of architectures is computed.  Are these linked in some way I'm missing?

I don't have a strong opinion about whether this callback belongs in ArchSpec, but I don't think it belongs in Process.  We've been trying hard to keep the algorithms in Process architecture independent, and that seems a worthy goal since otherwise it's going to be too easy to let little architecture specific hacks creep in and make the logic harder to follow.  If you have some strong reason to take this out of ArchSpec then maybe we need another container for architecture specific algorithms.  But I don't think Process is the right place for this.


https://reviews.llvm.org/D31172