[Lldb-commits] [PATCH] D31172: Move stop info override callback code from ArchSpec into Process

[Zachary Turner via Phabricator via lldb-commits]

zturner added a comment.

The architecture help change snuck in, I already removed it locally but didn't re-upload.

As for why I'm trying to get this out of `ArchSpec`, it turns out `ArchSpec` is one of the biggest causes of dependency cycles.  It's used all over the place, which triggers a dependency from Everywhere -> Core, and then it depends on Target, a couple of Plugins, and Host.  There's only a very small amount of code in `ArchSpec` that accounts for all of these dependencies though.  The first is this code that I'm attempting to move, the second is the code to set the triple given a Platform.  So I wanted to tackle these one at a time.

One option would be to make `lldb/Process/StopInfoOverride.h` and cpp, and put the code there.  Thoughts?


https://reviews.llvm.org/D31172