[Lldb-commits] [PATCH] D30624: Remove all of LLDB's custom filesystem statting code.
Pavel Labath via lldb-commits
lldb-commits at lists.llvm.org
Tue Mar 7 07:04:09 PST 2017
Yea, that would do the trick.
On 7 March 2017 at 14:47, Zachary Turner <zturner at google.com> wrote:
> I think i can address this by adding a bool to llvm::sys::fs::status which
> indicates whether to follow symlinks
> On Tue, Mar 7, 2017 at 5:41 AM Pavel Labath via Phabricator
> <reviews at reviews.llvm.org> wrote:
>> labath added a comment.
>> Zachary, unfortunately I had to revert this -- while investigating the
>> breakages I've found a problem I don't think any of us realised -- llvm's
>> statting code is based on stat(2), while lldb uses lstat(2). I think we need
>> to go back and re-audit each case to see whether the behavior difference is
>> a problem. In most of the cases, I think using stat would make things
>> simpler (no need to special case symlink as a file type), but at least one
>> case (SymbolFileDWARF) really depends on the lstat behavior (not resolving
>> symlinks), so we need to figure out how to handle that.
>> rL LLVM
More information about the lldb-commits