[Lldb-commits] [PATCH] D30624: Remove all of LLDB's custom filesystem statting code.

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 7 06:47:05 PST 2017

I think i can address this by adding a bool to llvm::sys::fs::status which
indicates whether to follow symlinks
On Tue, Mar 7, 2017 at 5:41 AM Pavel Labath via Phabricator <
reviews at reviews.llvm.org> wrote:

> labath added a comment.
> Zachary, unfortunately I had to revert this -- while investigating the
> breakages I've found a problem I don't think any of us realised -- llvm's
> statting code is based on stat(2), while lldb uses lstat(2). I think we
> need to go back and re-audit each case to see whether the behavior
> difference is a problem. In most of the cases, I think using stat would
> make things simpler (no need to special case symlink as a file type), but
> at least one case (SymbolFileDWARF) really depends on the lstat behavior
> (not resolving symlinks), so we need to figure out how to handle that.
> Repository:
>   rL LLVM
> https://reviews.llvm.org/D30624
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170307/021aad0a/attachment.html>

More information about the lldb-commits mailing list