[Lldb-commits] [PATCH] D30560: Split DataExtractor into two classes.

[Zachary Turner via lldb-commits]

I was actually thinking of making the dump functions free functions that
take a const DataExtractor&. This way the entire implementation could
remain unchanged with the exception of replacing implicit member variable
reads with reads through an explicit instance of the extractor.

This way we don't lose the ability to dump arbitrary DataExtractors and
don't have to introduce a class for no practical benefit
On Thu, Mar 2, 2017 at 6:45 PM Jim Ingham via Phabricator <
reviews at reviews.llvm.org> wrote:

> jingham added a comment.
>
> The EH stuff should definitely go in a specific subclass.
>
> It also seems a shame to lose the capability to Dump DataExtractors in
> general.  The only thing the exe_scope is used for in Dump (which is what
> is causing you problems) is to print instructions, and to do a more
> accurate job of printing non-native floats.  It would be best to leave the
> Dump without these bits in the base data extractor, and return an error for
> the unsupported format kinds, and then add a Dump method that takes an
> exe_scope in the subclass (now DataExtractorTargetAware???)
>
>
> https://reviews.llvm.org/D30560
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170303/cc74ec26/attachment.html>