[Lldb-commits] [PATCH] D30560: Split DataExtractor into two classes.

[Zachary Turner via Phabricator via lldb-commits]

zturner updated this revision to Diff 90432.
zturner added a comment.

I basically turned the two dump methods into free functions and moved the DWARF specific function into `DWARFCallFrameInfo.cpp`.  I think this is much better than before, as we don't muck with the inheritance hierarchy at all (removes a lot of code churn), and the header is very appropriately named.


https://reviews.llvm.org/D30560

Files:
  lldb/include/lldb/Core/DataExtractor.h
  lldb/include/lldb/Core/DumpDataExtractor.h
  lldb/include/lldb/Symbol/CompilerType.h
  lldb/include/lldb/Symbol/DWARFCallFrameInfo.h
  lldb/include/lldb/Symbol/Type.h
  lldb/source/API/SBData.cpp
  lldb/source/Commands/CommandObjectMemory.cpp
  lldb/source/Core/Address.cpp
  lldb/source/Core/CMakeLists.txt
  lldb/source/Core/DataExtractor.cpp
  lldb/source/Core/DumpDataExtractor.cpp
  lldb/source/Core/Event.cpp
  lldb/source/Core/RegisterValue.cpp
  lldb/source/DataFormatters/TypeFormat.cpp
  lldb/source/Expression/Materializer.cpp
  lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp
  lldb/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp
  lldb/source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.h
  lldb/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp
  lldb/source/Symbol/ClangASTContext.cpp
  lldb/source/Symbol/CompilerType.cpp
  lldb/source/Symbol/DWARFCallFrameInfo.cpp
  lldb/source/Symbol/GoASTContext.cpp
  lldb/source/Symbol/JavaASTContext.cpp
  lldb/source/Symbol/OCamlASTContext.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30560.90432.patch
Type: text/x-patch
Size: 106827 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170303/46b977e5/attachment-0001.bin>