[Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for 32 bit big endian system

Nitesh Jain via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 11 02:56:07 PDT 2016


This revision was automatically updated to reflect the committed changes.
Closed by commit rL283728: [LLDB][MIPS] Fix register read/write for 32 bit big endian system (authored by nitesh.jain).

Changed prior to commit:
  https://reviews.llvm.org/D24124?vs=72024&id=74202#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D24124

Files:
  lldb/trunk/source/Core/RegisterValue.cpp
  lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp


Index: lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp
===================================================================
--- lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp
+++ lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp
@@ -169,7 +169,7 @@
 
   if (error.Success())
     // First cast to an unsigned of the same size to avoid sign extension.
-    value.SetUInt64(static_cast<unsigned long>(data));
+    value.SetUInt(static_cast<unsigned long>(data), size);
 
   if (log)
     log->Printf("NativeRegisterContextLinux::%s() reg %s: 0x%lx", __FUNCTION__,
Index: lldb/trunk/source/Core/RegisterValue.cpp
===================================================================
--- lldb/trunk/source/Core/RegisterValue.cpp
+++ lldb/trunk/source/Core/RegisterValue.cpp
@@ -633,8 +633,11 @@
     default:
       break;
     case 1:
+      return *(const uint8_t *)buffer.bytes;
     case 2:
+      return *(const uint16_t *)buffer.bytes;
     case 4:
+      return *(const uint32_t *)buffer.bytes;
     case 8:
       return *(const uint64_t *)buffer.bytes;
     }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24124.74202.patch
Type: text/x-patch
Size: 1130 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20161011/11aad58c/attachment.bin>


More information about the lldb-commits mailing list