[Lldb-commits] [lldb] r283849 - Add a second, more complicated, arm64 example program to

[Zachary Turner via lldb-commits]

On Mon, Oct 10, 2016 at 8:53 PM Jason Molenda via lldb-commits <
lldb-commits at lists.llvm.org> wrote:

> Author: jmolenda
>
> Date: Mon Oct 10 22:44:48 2016
>
> New Revision: 283849
>
>
>
> URL: http://llvm.org/viewvc/llvm-project?rev=283849&view=rev
>
> Log:
>
> Add a second, more complicated, arm64 example program to
>
> the arm64 assembly unwind tests.
>
>
>
> Modified:
>
>
> lldb/trunk/unittests/UnwindAssembly/InstEmulation/TestArm64InstEmulation.cpp
>
>
>
> Modified:
> lldb/trunk/unittests/UnwindAssembly/InstEmulation/TestArm64InstEmulation.cpp
>
> URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/UnwindAssembly/InstEmulation/TestArm64InstEmulation.cpp?rev=283849&r1=283848&r2=283849&view=diff
>
>
> ==============================================================================
>
> ---
> lldb/trunk/unittests/UnwindAssembly/InstEmulation/TestArm64InstEmulation.cpp
> (original)
>
> +++
> lldb/trunk/unittests/UnwindAssembly/InstEmulation/TestArm64InstEmulation.cpp
> Mon Oct 10 22:44:48 2016
>
> @@ -56,7 +56,7 @@ static void terminate() {
>
>    EmulateInstructionARM64::Terminate();
>
>  }
>
>
>
> -TEST_F(TestArm64InstEmulation, TestSimpleFunction) {
>
> +TEST_F(TestArm64InstEmulation, TestSimpleDarwinFunction) {
>
>
>
>    init();
>
>
>
> @@ -64,16 +64,14 @@ TEST_F(TestArm64InstEmulation, TestSimpl
>
>    UnwindAssemblyInstEmulation *engine =
>
>        static_cast<UnwindAssemblyInstEmulation *>(
>
>            UnwindAssemblyInstEmulation::CreateInstance(arch));
>
> -  EXPECT_TRUE(engine != nullptr);
>
> -  if (engine == nullptr)
>
> -    return;
>
> +  ASSERT_NE(engine, nullptr);
>
I know I'm annoying, but nullptr should come first for the error message.
 :)  BTW don't feel obligated to fix everything I point out, just throwing
these things out there as minor nits.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20161011/676e49f8/attachment-0001.html>