[Lldb-commits] [lldb] r280344 - XFail TestMemoryFind on 32-bit architectures

[Pavel Labath via lldb-commits]

Yeah, sorry about that, I wrote that message in a hurry.

This was a generic issue with expressions in backticks (``) concerning the
printing of pointers (or even integers, as I later found out) of different
sizes. Basically a 64-bit pointer would get printed as a decimal value, but
a 32-bit one in hex. So when you wrote "memory find `stringdata`", in the
32bit case, the "find" command got the wrong address and could not find the
string properly. I have put up <https://reviews.llvm.org/D24126> to address
that.

pl

On 1 September 2016 at 19:19, Enrico Granata <egranata at apple.com> wrote:

> I am probably being a little dense right now, but I can't seem to find
> (const char*)0x1000 anywhere in the test case code...
>
> On Sep 1, 2016, at 2:17 AM, Pavel Labath via lldb-commits <
> lldb-commits at lists.llvm.org> wrote:
>
> Author: labath
> Date: Thu Sep  1 04:17:37 2016
> New Revision: 280344
>
> URL: http://llvm.org/viewvc/llvm-project?rev=280344&view=rev
> Log:
> XFail TestMemoryFind on 32-bit architectures
>
> the test fails for a very prosaic reason: `(const char *)0x1000` returns
> "4096" on x86_64 and
> "1000" (without the "0x") on i386. I haven't tried other 32-bit arches,
> but I am guessing the
> behaviour is the same. XFAIL until someone can get a chance to look at
> this.
>
> Modified:
>    lldb/trunk/packages/Python/lldbsuite/test/functionalities/memory/find/
> TestMemoryFind.py
>
> Modified: lldb/trunk/packages/Python/lldbsuite/test/
> functionalities/memory/find/TestMemoryFind.py
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/
> Python/lldbsuite/test/functionalities/memory/find/
> TestMemoryFind.py?rev=280344&r1=280343&r2=280344&view=diff
> ============================================================
> ==================
> --- lldb/trunk/packages/Python/lldbsuite/test/functionalities/memory/find/TestMemoryFind.py
> (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/memory/find/TestMemoryFind.py
> Thu Sep  1 04:17:37 2016
> @@ -11,6 +11,7 @@ import re
> import lldb
> from lldbsuite.test.lldbtest import *
> import lldbsuite.test.lldbutil as lldbutil
> +from lldbsuite.test.decorators import *
>
> class MemoryFindTestCase(TestBase):
>
> @@ -22,6 +23,7 @@ class MemoryFindTestCase(TestBase):
>         # Find the line number to break inside main().
>         self.line = line_number('main.cpp', '// break here')
>
> +    @expectedFailureAll(archs=["i386", "arm"])
>     def test_memory_find(self):
>         """Test the 'memory find' command."""
>         self.build()
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
>
>
> Thanks,
> *- Enrico*
> 📩 egranata@.com ☎️ 27683
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160902/84b6c472/attachment.html>