<div dir="ltr">Yeah, sorry about that, I wrote that message in a hurry.<div><br></div><div>This was a generic issue with expressions in backticks (``) concerning the printing of pointers (or even integers, as I later found out) of different sizes. Basically a 64-bit pointer would get printed as a decimal value, but a 32-bit one in hex. So when you wrote "memory find `stringdata`", in the 32bit case, the "find" command got the wrong address and could not find the string properly. I have put up <<a href="https://reviews.llvm.org/D24126">https://reviews.llvm.org/D24126</a>> to address that.</div><div><br></div><div>pl</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 1 September 2016 at 19:19, Enrico Granata <span dir="ltr"><<a href="mailto:egranata@apple.com" target="_blank">egranata@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>I am probably being a little dense right now, but I can't seem to find (const char*)0x1000 anywhere in the test case code...</div><div><div class="h5"><br><div><blockquote type="cite"><div>On Sep 1, 2016, at 2:17 AM, Pavel Labath via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:</div><br class="m_-7402674097318268779Apple-interchange-newline"><div><div>Author: labath<br>Date: Thu Sep 1 04:17:37 2016<br>New Revision: 280344<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=280344&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=280344&view=rev</a><br>Log:<br>XFail TestMemoryFind on 32-bit architectures<br><br>the test fails for a very prosaic reason: `(const char *)0x1000` returns "4096" on x86_64 and<br>"1000" (without the "0x") on i386. I haven't tried other 32-bit arches, but I am guessing the<br>behaviour is the same. XFAIL until someone can get a chance to look at this.<br><br>Modified:<br> lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/memory/find/<wbr>TestMemoryFind.py<br><br>Modified: lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/memory/find/<wbr>TestMemoryFind.py<br>URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/memory/find/TestMemoryFind.py?rev=280344&r1=280343&r2=280344&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/packages/<wbr>Python/lldbsuite/test/<wbr>functionalities/memory/find/<wbr>TestMemoryFind.py?rev=280344&<wbr>r1=280343&r2=280344&view=diff</a><br>==============================<wbr>==============================<wbr>==================<br>--- lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/memory/find/<wbr>TestMemoryFind.py (original)<br>+++ lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/memory/find/<wbr>TestMemoryFind.py Thu Sep 1 04:17:37 2016<br>@@ -11,6 +11,7 @@ import re<br> import lldb<br> from lldbsuite.test.lldbtest import *<br> import lldbsuite.test.lldbutil as lldbutil<br>+from lldbsuite.test.decorators import *<br><br> class MemoryFindTestCase(TestBase):<br><br>@@ -22,6 +23,7 @@ class MemoryFindTestCase(TestBase):<br> # Find the line number to break inside main().<br> self.line = line_number('main.cpp', '// break here')<br><br>+ @expectedFailureAll(archs=[<wbr>"i386", "arm"])<br> def test_memory_find(self):<br> """Test the 'memory find' command."""<br> self.build()<br><br><br>______________________________<wbr>_________________<br>lldb-commits mailing list<br><a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/lldb-commits</a><br></div></div></blockquote></div><br></div></div><div>
<div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br class="m_-7402674097318268779Apple-interchange-newline">Thanks,</div><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><i>- Enrico</i><br>📩 egranata@<font color="#ff2600"></font>.com ☎️ 27683</div>
</div>
<br></div></blockquote></div><br></div>