[Lldb-commits] [PATCH] D23545: Minidump parsing

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 26 03:31:28 PDT 2016

labath added a comment.

Looks fine to me. Adrian, Zachary, any more thoughts here?

Comment at: source/Plugins/Process/minidump/MinidumpParser.h:42
@@ +41,3 @@
+    explicit MinidumpParser(const lldb::DataBufferSP &data_buf_sp, const MinidumpHeader *header,
+                            const llvm::DenseMap<uint32_t, MinidumpLocationDescriptor> &directory_map);
If you have a `Create` function, the constructor should probably be private (also, `explicit` is not necessary anymore).


More information about the lldb-commits mailing list