[Lldb-commits] [PATCH] D23545: Minidump parsing
Dimitar Vlahovski via lldb-commits
lldb-commits at lists.llvm.org
Thu Aug 25 08:38:45 PDT 2016
dvlahovski added a comment.
I changed all of the `llvm::Optional<const type *>` returning functions to return only `const type *`
and signalize for 'failure' by returning a `nullptr`. In the cases where I return objects (e.g. vector of threads)
I'm still using the `llvm::Optional` pattern.
I also think that using `llvm::Error` is a good idea, but I think that it'll be difficult, because of
collisions with the `lldb::Error`, and also at some point I have to convert objects from one type to the other.
So that's why I stick to the `llvm::Optional`.
I also used it on the creation of `MinidumpParser` (following somewhat the pattern that you proposed)
More information about the lldb-commits