[Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR

[Nitesh Jain via lldb-commits]

nitesh.jain added inline comments.

================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:98
@@ +97,3 @@
+    const ArchSpec &arch = m_thread.GetProcess()->GetTarget().GetArchitecture();
+    RegisterInfo* reg_info = const_cast<RegisterInfo *>(m_reg_info.GetRegisterInfoAtIndex (reg));
+    if(reg_info->dynamic_size_dwarf_len)
----------------
labath wrote:
> Can we get rid of these const_casts? It looks like UpdateDynamicRegisterSize does not actually need this to be non-const.
No, it require so that we can modify the reg_info->byte_size member.


Repository:
  rL LLVM

http://reviews.llvm.org/D20357